bench: update benchmarks to use decimal literals - #13849
Merged
kgryte merged 1 commit intoAug 1, 2026
Merged
Conversation
Decimal values out, decimal values in. When generating random decimal values via `@stdlib/random/array/uniform`, range arguments should be decimal literals.
anandkaranubc
added
Benchmarks
Contributor
Author
|
So many changes but the diff contains nothing but those literal changes only. 😅 |
kgryte
approved these changes
Aug 1, 2026
kgryte
left a comment
kgryte
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the clean-up!
Member
|
I'll go ahead and merge this on the assumption that CI should either pass or fail for expected reasons. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
blas/ext/base,stats/array,stats/strided,stats/base, andmath/baseto use decimal literals when generating random decimal values via@stdlib/random/array/uniform(e.g.,uniform( len, -100, 100, options )=>uniform( len, -100.0, 100.0, options )). Decimal values out, decimal values in.This follows up on review feedback in #13845 (comment). Only benchmark files requiring the continuous
@stdlib/random/array/uniformgenerator were updated;discreteUniformusage (integer values out, integer values in) was intentionally left unchanged.Related Issues
stdlib-js/metr-issue-tracker#1098
Questions
No.
Other
The change was applied mechanically and verified: all 453 updated files bind
uniformto@stdlib/random/array/uniform, the diff contains onlyuniform( len, ... )range-argument literal changes, and no examples, tests, or source files were modified.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Used Claude Code to scan for affected files and apply the mechanical literal updates.
@stdlib-js/reviewers